correct gofmt of vtctld and re-sync go.mod#5766
Merged
systay merged 1 commit intovitessio:masterfrom Jan 28, 2020
Merged
Conversation
This addresses symptoms, but not causes, discussed in vitessio#5755 and vitessio#5756 Signed-off-by: Jeff Hodges <jeff@somethingsimilar.com>
Contributor
Author
|
This failed because of some remote apt repo failing. Could I get a re-run? |
Contributor
|
I've triggered a rebuild. |
Contributor
Author
|
Weird panic in the cluster_end / build (15) run that doesn't seem related? |
Collaborator
jmhodges
added a commit
to jmhodges/vitess
that referenced
this pull request
Jan 29, 2020
This is a significant, but not complete expansion of the ALTER support in sqlparser. It adds support for these ALTER commands: * `ADD COLUMN` * `DROP COLUMN` * `ADD INDEX` * `DROP INDEX` * `DROP FOREIGN KEY` * `DROP PRIMARY KEY` * `ADD PARTITION` * `DROP PARTITION` * `ADD CHECK` (as a no-op; it's parsed but never executed by mysql servers) The main addition with this API is an additional field on `DDL` that is a slice of newly created `AlterSpecs`. An `AlterSpec` represents one of the commands that can occur in the same `ALTER` statement with other commands. This differentiates them from the `ALTER` statement parse states already in `sql.y` which are concerned with `ALTER` commands that must be the sole commands in the statement. The `ADD PARTITION` and `DROP PARTITION` states are the exception and are new singleton commands that `sql.y` now supports. This patch also includes some incidental updates to `go.mod` because of tooling issues (described in vitessio#5755) and are duplicated in vitessio#5766 Updates vitessio#5705 Signed-off-by: Jeff Hodges <jeff@somethingsimilar.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses symptoms, but not causes, discussed in #5755 and #5756
Signed-off-by: Jeff Hodges jeff@somethingsimilar.com