helm/vitess/templates/_vtctld.tpl: Revert web_dir changes#5744
Merged
morgo merged 1 commit intovitessio:masterfrom Jan 21, 2020
Merged
helm/vitess/templates/_vtctld.tpl: Revert web_dir changes#5744morgo merged 1 commit intovitessio:masterfrom
morgo merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Gary Edgar <gary@planetscale.com>
Contributor
|
I chatted with @rohit-nayak-ps on this, and I think what we will do is make Vitess 5.0 support these two parameters as a noop, and then remove them in Vitess 6.0. So with that understanding, this looks good to merge for handling 4.0, and 5.0 with Rohit's fix (planned to work on tomorrow). We can then remove this again towards the start of the 6.0 development cycle. |
morgo
approved these changes
Jan 21, 2020
Contributor
|
The related patch is #5747 (noop if these options are specified). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5720 until we can push a helm v2.0 release alongside 5.0.
See this comment.
CC @derekperkins @morgo @rohit-nayak-ps
Signed-off-by: Gary Edgar gary@planetscale.com