Deprecate disable_local_gateway flag.#5741
Merged
deepthi merged 1 commit intovitessio:masterfrom Jan 21, 2020
Merged
Conversation
…ng with l2vtgate functionality Signed-off-by: deepthi <deepthi@planetscale.com>
Collaborator
Author
|
@morgo this will need to go into release notes, and we should remember to delete the flag for the next release. |
morgo
approved these changes
Jan 21, 2020
Contributor
morgo
left a comment
morgo
left a comment
There was a problem hiding this comment.
LGTM. I like the mapping of it to _. That makes it easier to keep track of while knowing that it is not in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag should have been removed along with l2vtgate functionality.
Also remove reference to l2vtgate in comments.
Signed-off-by: deepthi deepthi@planetscale.com