Skip to content

Address #5734 by forming MySQL error packet on query parse error during #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Jan 19, 2020
Merged

Address #5734 by forming MySQL error packet on query parse error during #5735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion go/mysql/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,12 @@ func (c *Conn) handleNextCommand(handler Handler) error {

statement, err := sqlparser.ParseStrictDDL(query)
if err != nil {
return err
log.Errorf("Conn %v: Error parsing prepared statement: %v", c, err)
if werr := c.writeErrorPacketFromError(err); werr != nil {
// If we can't even write the error, we're done.
log.Errorf("Conn %v: Error writing prepared statement error: %v", c, werr)
return werr
}
}

paramsCount := uint16(0)
Expand Down