mysqlctld: allow setting flags / env vars for mysqld#5730
Merged
morgo merged 2 commits intovitessio:masterfrom Jan 21, 2020
Merged
mysqlctld: allow setting flags / env vars for mysqld#5730morgo merged 2 commits intovitessio:masterfrom
morgo merged 2 commits intovitessio:masterfrom
Conversation
The confirmation for the signoff prompt wasn't being processed. Signed-off-by: Siva Kommuri <snv.kommuri@gmail.com>
* Build the LD_LIBRARY_PATH environment variable in a new function * Inherit LD_PRELOAD as an environment variable for all mysql* commands Signed-off-by: Siva Kommuri <snv.kommuri@gmail.com>
Contributor
|
@neowulf Cleanup is looking good. We have a couple of options here: in the 5.0 release notes, vtMysqlRoot and vtroot are called out as deprecated. If you wait a week for 5.0 to branch, we can remove these options and rely exclusively on finding the binaries in the |
Contributor
Author
|
Thank you for the quick feedback! Sounds good! I can help clean up the lingering vt*root variables post 5.0. |
neowulf
changed the title
This was referenced Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow LD_PRELOAD to be added to the execution environment
Fixes #5466