Fix regression introduced by #5326#5704
Merged
morgo merged 1 commit intovitessio:masterfrom Jan 13, 2020
Merged
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Contributor
Author
|
The MySQL 8.0 unit test was disabled today (due to 8.0.19 release breaking our install). Here is the result of a manual unit test (success): |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of refactoring, #5326 changed the config files so that MySQL would not overwrite a default if one was set. With the binary log enabled in MySQL 8.0, it moved the log-bin directive into the per-version config files, since this was no longer a var that needs to change in all versions.
This logic was incorrect for two reasons
BinLogPath.BinLogPathwas not set in any of the per-version configs.Thus, this has been moved back to a global variable, that applies for all versions.
Signed-off-by: Morgan Tocker tocker@gmail.com