Skip to content

Adds context to sqlparser errors#5690

Merged
sougou merged 2 commits intovitessio:masterfrom
cmoog:pos_parse_err
Jan 19, 2020
Merged

Adds context to sqlparser errors#5690
sougou merged 2 commits intovitessio:masterfrom
cmoog:pos_parse_err

Conversation

@cmoog
Copy link
Copy Markdown
Contributor

@cmoog cmoog commented Jan 11, 2020

Addresses #5682

Allows consumers of sqlparser parsing errors to inspect Pos and Near fields without depending on the format of the error message itself.

@cmoog cmoog requested a review from sougou as a code owner January 11, 2020 05:09
Signed-off-by: cmoog <moogcharlie@gmail.com>
@cmoog cmoog closed this Jan 14, 2020
@cmoog cmoog deleted the pos_parse_err branch January 14, 2020 03:10
@cmoog cmoog reopened this Jan 14, 2020
Signed-off-by: cmoog <moogcharlie@gmail.com>
Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice unintrusive change.

@sougou sougou merged commit 824f835 into vitessio:master Jan 19, 2020
sougou added a commit that referenced this pull request Jan 19, 2020
trivial patch to #5690 testing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants