Updates how master gtid position is obtained for file:pos flavor#5689
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 11, 2020
Merged
Conversation
When generating masterGTIDSet in file:pos most likely you will have a topology like the following: Source A -> Target B (B has a vreplication stream from A) From the target perspective, the source A is the master and you want to generate a gtid that is based on binlog file position of that server. As an example, let's see this topology: Master A -> Source B -> Target C (C has vreplication stream from B) Prior to this change, masterGTIDSet was returning the binlogfile:pos of A. But in reality, the Target C wants the position of B. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
sougou
approved these changes
Jan 11, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
This is fine. Essentially, you can't use this flavor for anything other than vreplication. And for that context, this is the right behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When generating masterGTIDSet in file:pos most likely you will have a topology
like the following:
From the target perspective, the source A is the master and you want to generate
a gtid that is based on binlog file position of
Source A.As an example, let's see this topology:
Prior to this change,
masterGTIDSetwas returning the binlogfile:pos ofMaster A. Butin reality, the
Target Cwants the position ofSource B.