Skip to content

Fixes bug in filepos flavor#5688

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:fix-comparison-bug-filepos-flavor
Jan 10, 2020
Merged

Fixes bug in filepos flavor#5688
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:fix-comparison-bug-filepos-flavor

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Jan 10, 2020

Description

  • Prior to this commit, flavorpos was using lexicographical comparison of gtids. We discovered that a position like this 99761227 was returning true when it checked if it contain: 103939867 .
  • The following PR fixes this issue and adds some tests to prevent future regressions.
    Signed-off-by: Rafael Chacon rafael@slack-corp.com

* Prior to this commit, flavorpos was using lexicographical comparison of the gtids.
  Thas was a bug in this context.

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner January 10, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants