Add slim Docker file for functional testing using vttestserver#5680
Merged
sougou merged 1 commit intovitessio:masterfrom Jun 15, 2020
Merged
Conversation
kalfonso
requested review from
derekperkins,
dkhenry and
sougou
as code owners
kalfonso
force-pushed
the
kalfonso.200108-vttestserver-docker
branch
from
bba34cc to
c5855bd
Compare
Contributor
Author
|
To use this image the schema folder must be copied to a known location within the container and point |
Contributor
|
@kalfonso LGTM in principle. This is not an area I understand well, may I ask what functionality the |
Contributor
Author
|
@morgo this allows to use only the minimum binaries required to run vttestserver(it uses vtcombo) which we use in our integration tests with Docker. The other Vitess/lite images are fine for production but I wanted to have a lite image to run vttestserver and thought it was good to share upstream |
Contributor
|
@kalfonso can you resolve merge conflicts? |
Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com>
kalfonso
force-pushed
the
kalfonso.200108-vttestserver-docker
branch
from
c5855bd to
d04f452
Compare
sougou
approved these changes
Jun 15, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Whoa. This fell through the cracks. Sorry about the delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the vitess/lite image which will provide as slim down version to use in testing