Skip to content

Advertise support for FOUND ROWS from server#5676

Merged
morgo merged 2 commits intovitessio:masterfrom
planetscale:tj-server-found-rows-advertise
Jan 9, 2020
Merged

Advertise support for FOUND ROWS from server#5676
morgo merged 2 commits intovitessio:masterfrom
planetscale:tj-server-found-rows-advertise

Conversation

@teejae
Copy link
Copy Markdown
Contributor

@teejae teejae commented Jan 9, 2020

Add FOUND ROWS capability to list of supported capabilities advertised by server to client.

#5675

Signed-off-by: Toliver Jue toliver@planetscale.com

Signed-off-by: Toliver Jue <toliver@planetscale.com>
@teejae teejae requested a review from sougou as a code owner January 9, 2020 09:06
Signed-off-by: Toliver Jue <toliver@planetscale.com>
@deepthi deepthi requested a review from morgo January 9, 2020 17:00
Copy link
Copy Markdown
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For context, I double-checked and this is the capability to "Send found rows instead of affected rows in EOF_Packet." It does not relate to:
#3904

@morgo morgo merged commit 4e6931d into vitessio:master Jan 9, 2020
@teejae teejae deleted the tj-server-found-rows-advertise branch January 9, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants