Skip to content

prepared statement testcases#5670

Merged
sougou merged 5 commits intovitessio:masterfrom
princeparmar:prepared-statement
Jan 19, 2020
Merged

prepared statement testcases#5670
sougou merged 5 commits intovitessio:masterfrom
princeparmar:prepared-statement

Conversation

@princeparmar
Copy link
Copy Markdown
Contributor

@princeparmar princeparmar commented Jan 8, 2020

verifies insert,update,delete and select for prepared statements.
Fixes #5524

Signed-off-by: pradip parmar prince.soamedia@gmail.com

@princeparmar princeparmar requested a review from sougou as a code owner January 8, 2020 11:15
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits and changes to doc comments.
I'm assuming this covers all cases from the original python test.

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 15, 2020

You will need to resolve the DCO and merge conflict.
Please get @ajeetj or @arindamnayak to help if needed.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@princeparmar princeparmar reopened this Jan 16, 2020
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 17, 2020

sorry, merging your other PR created conflicts in this one. Can you resolve them?

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@sougou sougou merged commit 7fe2822 into vitessio:master Jan 19, 2020
@princeparmar princeparmar deleted the prepared-statement branch January 20, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepared_statement test triggers segfault

3 participants