Skip to content

xtrabackup: Add a buffered reader in front of xtrabackup's stdout pipe. #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepthi merged 1 commit into from
Jan 9, 2020
+5 −1
Merged

xtrabackup: Add a buffered reader in front of xtrabackup's stdout pipe. #5666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion go/vt/mysqlctl/xtrabackupengine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,11 @@ func (be *XtrabackupEngine) backupFiles(ctx context.Context, params BackupParams
// Enforce minimum block size.
blockSize = 1024
}
if _, err := copyToStripes(destWriters, backupOut, blockSize); err != nil {
// Add a buffer in front of the raw stdout pipe so io.CopyN() can use the
// buffered reader's WriteTo() method instead of allocating a new buffer
// every time.
backupOutBuf := bufio.NewReaderSize(backupOut, int(blockSize))
if _, err := copyToStripes(destWriters, backupOutBuf, blockSize); err != nil {
return replicationPosition, vterrors.Wrap(err, "cannot copy output from xtrabackup command")
}

Expand Down