Added encrypted_transport testcase migrated in go#5664
Merged
deepthi merged 2 commits intovitessio:masterfrom Jan 8, 2020
Merged
Added encrypted_transport testcase migrated in go#5664deepthi merged 2 commits intovitessio:masterfrom
deepthi merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: saurabh <saurabh.408@gmail.com>
ajeetj
reviewed
Jan 7, 2020
Contributor
ajeetj
left a comment
ajeetj
left a comment
There was a problem hiding this comment.
Overall looks good.
Small nit-picks here and there mentioned below.
| err = clusterInstance.VtctlclientProcess.InitTablet(&replicaTablet, clusterInstance.Cell, keyspace, hostname, shardName) | ||
| assert.Nil(t, err) | ||
| err = replicaTablet.VttabletProcess.CreateDB(keyspace) | ||
| assert.Nil(t, err) |
Contributor
There was a problem hiding this comment.
Maybe use in a loop
for _, tablet := range []cluster.Vttablet{*masterTablet, *replicaTablet} {
}
Comment on lines
+133
to
+134
| } | ||
| ] |
|
|
||
| // Reparenting | ||
| vtctlClientArgs = append(vtctlClientTmArgs, "InitShardMaster", "-force", "test_keyspace/0", masterTablet.Alias) | ||
| _, err = clusterInstance.VtctlProcess.ExecuteCommandWithOutput(vtctlClientArgs...) |
Contributor
There was a problem hiding this comment.
As you don't need a result here maybe write another method in VtctlProcess which just returns err?
| for i := 0; i < 2; i++ { | ||
| // instantiate vttablet object with reserved ports | ||
| tabletUID := clusterInstance.GetAndReserveTabletUID() | ||
| tablet := clusterInstance.GetVttabletInstance("replica", tabletUID, cell) |
Contributor
There was a problem hiding this comment.
nit: if you can pass tabletUID=0 then you don't need to call separate tabletUID := clusterInstance.GetAndReserveTabletUID()
Signed-off-by: saurabh <saurabh.408@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypted transport tests :
Signed-off-by: saurabh saurabh.408@gmail.com