Skip to content

Fixed port in use issue occurs during testcase execution#5658

Merged
morgo merged 1 commit intovitessio:masterfrom
planetscale:tal_fix_port_in_use
Jan 6, 2020
Merged

Fixed port in use issue occurs during testcase execution#5658
morgo merged 1 commit intovitessio:masterfrom
planetscale:tal_fix_port_in_use

Conversation

@arindamnayak
Copy link
Copy Markdown
Contributor

Signed-off-by: Arindam Nayak arindam.nayak@outlook.com

With this change, we will save last used port to temp file in temp directory, so that subsequent testcases will start from that port and again save that to temp file. The file will be rotated daily. This way, we should not have any conflict on port. For testcase execution in CI, we don't have to worry about temp file clean up, as it is one time activity.

Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
@arindamnayak arindamnayak requested a review from sougou as a code owner January 6, 2020 06:28
@deepthi deepthi requested a review from morgo January 6, 2020 16:49
Copy link
Copy Markdown
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit 2d0b627 into vitessio:master Jan 6, 2020
@arindamnayak arindamnayak deleted the tal_fix_port_in_use branch January 7, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants