Merged
Conversation
deepthi
approved these changes
Jan 6, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good except for a couple of nits.
go/vt/vtctl/vtctl.go
Outdated
| "Start a Resharding process. Example: Reshard ks.workflow001 '0' '-80,80-'"}, | ||
| {"Migrate", commandMigrate, | ||
| "[-cell=<cell>] [-tablet_types=<tablet_types>] -workflow=<workflow> <source_keyspace> <target_keyspace> <table_specs>", | ||
| `Start a table(s) migration, table_specs is a list of tables or the tables section of the vschema for the target keyspace. Example: '{"t1":{}, "t2":{}}`}, |
Collaborator
There was a problem hiding this comment.
Can you give a more complex example in the help text?
Comment on lines
+1824
to
+1823
| if *workflow == "" { | ||
| return fmt.Errorf("a workflow name must be specified") | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: I would check this first, before checking the args.
| CreateDdl: "copy", | ||
| }) | ||
| } | ||
| return wr.Materialize(ctx, ms) |
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-vrepl-migrate
branch
from
a4b64e1 to
7178576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reuse the Materialize command to build the command to migrate tables from one keyspace to another. This works from any keyspace to any keyspace, and the MigrateReads and MigrateWrite commands can be used to migrate traffic.