Fix intermittent nil dereference error#5648
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
sougou
left a comment
There was a problem hiding this comment.
If this is what made it flaky, we should make it non-flaky. If not, it can stay the way it is.
I can't tell from the history whether this is the error we were getting earlier. |
|
Try running it 10 times in a row, bonus points if you can overload your box while doing this. If it consistently passes, we can make it non-flaky. |
Signed-off-by: deepthi <deepthi@planetscale.com>
It passes the stress test on my local, so I have made it non-flaky. |
Don't use err.Error() because it is possible for err to be nil.
Signed-off-by: deepthi deepthi@planetscale.com