-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Rewriter infrastructure revamp #5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
955f4f7
65a57ef
216d49d
6933419
070347d
16300d6
a0f6a81
8765802
b92fd33
3fef779
38bf74d
bd99abb
b6d18b7
8274354
5c242d3
a8f2ea1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ MAKEFLAGS = -s | |
| export GOBIN=$(PWD)/bin | ||
| export GO111MODULE=on | ||
| export GODEBUG=tls13=0 | ||
| export REWRITER=go/vt/sqlparser/rewriter.go | ||
|
|
||
| # Disabled parallel processing of target prerequisites to avoid that integration tests are racing each other (e.g. for ports) and may fail. | ||
| # Since we are not using this Makefile for compilation, limiting parallelism will not increase build time. | ||
|
|
@@ -87,6 +88,11 @@ install: build | |
| parser: | ||
| make -C go/vt/sqlparser | ||
|
|
||
| visitor: | ||
| go build -o visitorgen go/visitorgen/main/main.go | ||
| ./visitorgen -input=go/vt/sqlparser/ast.go -output=$(REWRITER) | ||
|
||
| rm ./visitorgen | ||
|
||
|
|
||
| # To pass extra flags, run test.go manually. | ||
| # For example: go run test.go -docker=false -- --extra-flag | ||
| # For more info see: go run test.go -help | ||
|
|
@@ -100,9 +106,10 @@ clean: | |
| go clean -i ./go/... | ||
| rm -rf third_party/acolyte | ||
| rm -rf go/vt/.proto.tmp | ||
| rm -rf ./visitorgen | ||
|
|
||
| # Remove everything including stuff pulled down by bootstrap.sh | ||
| cleanall: | ||
| cleanall: clean | ||
| # directories created by bootstrap.sh | ||
| # - exclude vtdataroot and vthook as they may have data we want | ||
| rm -rf bin dist lib pkg | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| /* | ||
|
||
| Copyright 2019 The Vitess Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package visitorgen | ||
|
|
||
| import ( | ||
| "go/ast" | ||
| "reflect" | ||
| ) | ||
|
|
||
| var _ ast.Visitor = (*walker)(nil) | ||
|
|
||
| type walker struct { | ||
| result SourceFile | ||
| } | ||
|
|
||
| // Walk walks the given AST and translates it to the simplified AST used by the next steps | ||
| func Walk(node ast.Node) *SourceFile { | ||
| var w walker | ||
| ast.Walk(&w, node) | ||
| return &w.result | ||
| } | ||
|
|
||
| // Visit implements the ast.Visitor interface | ||
| func (w *walker) Visit(node ast.Node) ast.Visitor { | ||
| switch n := node.(type) { | ||
| case *ast.TypeSpec: | ||
| switch t2 := n.Type.(type) { | ||
| case *ast.InterfaceType: | ||
| w.append(&InterfaceDeclaration{ | ||
| name: n.Name.Name, | ||
| block: "", | ||
| }) | ||
| case *ast.StructType: | ||
| var fields []*Field | ||
| for _, f := range t2.Fields.List { | ||
| for _, name := range f.Names { | ||
| fields = append(fields, &Field{ | ||
| name: name.Name, | ||
| typ: sastType(f.Type), | ||
| }) | ||
| } | ||
|
|
||
| } | ||
| w.append(&StructDeclaration{ | ||
| name: n.Name.Name, | ||
| fields: fields, | ||
| }) | ||
| case *ast.ArrayType: | ||
| w.append(&TypeAlias{ | ||
| name: n.Name.Name, | ||
| typ: &Array{inner: sastType(t2.Elt)}, | ||
| }) | ||
| case *ast.Ident: | ||
| w.append(&TypeAlias{ | ||
| name: n.Name.Name, | ||
| typ: &TypeString{t2.Name}, | ||
| }) | ||
|
|
||
| default: | ||
| panic(reflect.TypeOf(t2)) | ||
| } | ||
| case *ast.FuncDecl: | ||
| if len(n.Recv.List) > 1 || len(n.Recv.List[0].Names) > 1 { | ||
| panic("don't know what to do!") | ||
| } | ||
| var f *Field | ||
| if len(n.Recv.List) == 1 { | ||
| r := n.Recv.List[0] | ||
| t := sastType(r.Type) | ||
| if len(r.Names) > 1 { | ||
| panic("don't know what to do!") | ||
| } | ||
| if len(r.Names) == 1 { | ||
| f = &Field{ | ||
| name: r.Names[0].Name, | ||
| typ: t, | ||
| } | ||
| } else { | ||
| f = &Field{ | ||
| name: "", | ||
| typ: t, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| w.append(&FuncDeclaration{ | ||
| receiver: f, | ||
| name: n.Name.Name, | ||
| block: "", | ||
| arguments: nil, | ||
| }) | ||
| } | ||
|
|
||
| return w | ||
| } | ||
|
|
||
| func (w *walker) append(line Sast) { | ||
| w.result.lines = append(w.result.lines, line) | ||
| } | ||
|
|
||
| func sastType(e ast.Expr) Type { | ||
| switch n := e.(type) { | ||
| case *ast.StarExpr: | ||
| return &Ref{sastType(n.X)} | ||
| case *ast.Ident: | ||
| return &TypeString{n.Name} | ||
| case *ast.ArrayType: | ||
| return &Array{inner: sastType(n.Elt)} | ||
| case *ast.InterfaceType: | ||
| return &TypeString{"interface{}"} | ||
| case *ast.StructType: | ||
| return &TypeString{"struct{}"} | ||
| } | ||
|
|
||
| panic(reflect.TypeOf(e)) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we be calling this whenever there is a change to sql.y (and sql.go)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really. only when there is a change to
ast.goThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will people need to know to call this manually? is there a test that will catch it if someone forgets to do so after changing ast.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added pre-commit hook