Skip to content

vitess-mixin: add structure & first 2 dashboards#5609

Merged
sougou merged 1 commit intovitessio:masterfrom
guidoiaquinti:vitess_mixin
Jan 19, 2020
Merged

vitess-mixin: add structure & first 2 dashboards#5609
sougou merged 1 commit intovitessio:masterfrom
guidoiaquinti:vitess_mixin

Conversation

@guidoiaquinti
Copy link
Copy Markdown
Member

Description

First draft of the vitess-mixin: a set of Grafana dashboards, Prometheus rules and alerts, packaged together in a reuseable and extensible bundle.

Screen Shot 2019-12-20 at 4 32 43 PM

Why

Following the same path as other monitoring mixins. This mixin was heavily inspired by the kubernetes-mixin.

Disclaimer

This bundle is still a WIP:

  • It only generates Grafana dashboards
  • Prometheus rules and alerts are still missing
  • there's quite a bit of code duplication that could be refactored

I just rushed to push something out before 🎄Christmas to get a first feedback from the community.

Feedback are welcome, thanks and happy holidays!

Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
@dkhenry
Copy link
Copy Markdown
Contributor

dkhenry commented Jan 9, 2020

This looks like it might be a better fit in https://github.com/vitessio/contrib

@guidoiaquinti
Copy link
Copy Markdown
Member Author

👋@dkhenry thanks for your comment. I thought about it but I ended up pushing it here as this allow us to make changes to metrics and directly reflect those to Grafana dashboards, Prometheus rules and alerts at the same time without breaking anything. What do you think about it? Thanks!

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 16, 2020

This looks like it might be a better fit in https://github.com/vitessio/contrib

@dkhenry can you articulate why you don't think this should be in the main repo?

Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're willing to keep this up-to-date, then it's a good idea to make this part of the main repo. And I do trust that you will, since you're running this in production :).

@sougou sougou merged commit bd8205e into vitessio:master Jan 19, 2020
@guidoiaquinti guidoiaquinti deleted the vitess_mixin branch May 18, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants