vttablet: seq: make nextval more robust#5591
Merged
sougou merged 2 commits intovitessio:masterfrom Jan 21, 2020
Merged
Conversation
Collaborator
|
@kalfonso can you patch this into our staging environment and verify if it works please? |
Fixes vitessio#5590 Previously the nextval code assumed that next_id will be changed externally. As explained in the bug, this can now happen with the new use cases. This change ensures that vttablet will work correctly even if next_id was changed. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
Contributor
|
we haven't tested this change in our staging environment yet but it should happen in the next couple of days. |
Contributor
|
@sougou I've tested successfully your change using our chaos tests in a setting where there could be more than one master vttablet for a short period of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5590
Previously the nextval code assumed that next_id will be changed
externally. As explained in the bug, this can now happen with the
new use cases.
This change ensures that vttablet will work correctly even if
next_id was changed.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com