Support additional SHOW syntax#5579
Merged
sougou merged 4 commits intovitessio:masterfrom Jan 21, 2020
Merged
Conversation
Contributor
|
Tests seem badly broken. Can you rebase against master and force-push? |
saifalharthi
force-pushed
the
sa-fix-jira
branch
from
ad33cb4 to
ce51281
Compare
Signed-off-by: Saif Alharthi <saif@saifalharthi.me> Revert previous change (wrong branch!) Signed-off-by: Morgan Tocker <tocker@gmail.com> Resolve yaml conflict Signed-off-by: Saif Alharthi <saif@saifalharthi.me> vrepl: ExternalizeVindex Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com> vrepl: ExternalizeVindex vtctl command Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com> adds position and last token context to parse errors Signed-off-by: cmoog <moogcharlie@gmail.com> adds unit tests for PositionedErr parse error Signed-off-by: cmoog <moogcharlie@gmail.com> Add datadog plugin for tracing Signed-off-by: Karel Alfonso Sague <kalfonso@squareup.com> prepare statment test case. Signed-off-by: pradip parmar <prince.soamedia@gmail.com> prepared_statement: comments changes as per idiomatic go, removed elses. Signed-off-by: pradip parmar <prince.soamedia@gmail.com> prepared_statement: unwanted dependency removed. Signed-off-by: pradip parmar <prince.soamedia@gmail.com> prepare_statement: dummy commit. Signed-off-by: pradip parmar <prince.soamedia@gmail.com> patches error logic Signed-off-by: cmoog <moogcharlie@gmail.com> vitess-mixin: add structure & first 2 dashboards Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com> Address vitessio#5734 by forming MySQL error packet on query parse error during COM_PREPARE Signed-off-by: Jacques Grove <aquarapid@gmail.com>
saifalharthi
force-pushed
the
sa-fix-jira
branch
from
3ec7cad to
bd5c3db
Compare
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Contributor
|
Can you resolve conflicts? Also, this PR shows diffs from other PRs. You may have to rebase. |
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
sougou
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a comment in #5393 (comment)
SHOW syntax with this format
SHOW FULL COLUMNS FROM table FROM DATABASEare now supported.Signed-off-by: Saif Alharthi saif@saifalharthi.me