Skip to content

Refactoring of the visitor and rewriter for the AST#5525

Closed
systay wants to merge 8 commits intovitessio:masterfrom
systay:rewriter
Closed

Refactoring of the visitor and rewriter for the AST#5525
systay wants to merge 8 commits intovitessio:masterfrom
systay:rewriter

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Dec 7, 2019

Benefits with this way of doing it:

  • Rewriting of the full AST, not just expressions
  • Find matching nodes to rewrite with arbitrary logic, not just from, to equality
  • Slightly less code
  • Walking and rewriting done with the same infrastructure

@systay systay requested a review from sougou as a code owner December 7, 2019 14:50
@systay systay force-pushed the rewriter branch 10 times, most recently from fa0c0e6 to a1d2156 Compare December 10, 2019 16:44
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Copy link
Copy Markdown
Collaborator Author

systay commented Jan 6, 2020

Continue in #5611

@systay systay closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant