vreplication: keyspace_id() support#5500
Merged
sougou merged 1 commit intovitessio:masterfrom Dec 5, 2019
Merged
Conversation
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Contributor
Author
|
The retry succeeded even though build shows red. |
deepthi
approved these changes
Dec 4, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Requested more comments. Looks good otherwise.
| Vindex vindexes.Vindex | ||
| Alias sqlparser.ColIdent | ||
| Type querypb.Type | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you add comments for each field here? It isn't obvious that Vindex will be set only for keyspace_id func as of now.
Contributor
Author
There was a problem hiding this comment.
I'll update these on the next PR, because I've reorganized these a bit to accommodate multi-column vindexes.
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com