vreplication: Reshard command#5491
Merged
sougou merged 10 commits intovitessio:masterfrom Dec 4, 2019
Merged
Conversation
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
CreateShard starts off all unsharded shards as serving. It breaks if you create shards -80, 80-, and then 0 (with the intention to reshard to 0). It was previously allowed because we allowed the old style of custom sharding where you could create shards 0, 1, 2, etc. But we don't support that any more. The new rule sets master as serving only if the keyranges don't overlap. This is applied for unsharded keyspaces also. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Dec 3, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good except for the one question.
| {"Reshard", commandReshard, | ||
| "[-skip_schema_copy] <keyspace.workflow> <source_shards> <target_shards>", | ||
| "Start a Resharding process. Example: Reshard ks.workflow001 '0' '-80,80-'"}, | ||
| {"SplitClone", commandSplitClone, |
Collaborator
There was a problem hiding this comment.
are you not removing this command in this PR?
Contributor
Author
There was a problem hiding this comment.
It's better not to remove anything legacy right now. I'm thinking we should wait a couple of releases before removing these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the vtctl
Reshardcommand.This command replaces all previous
SplitCloneworkflows. After issuing this command and replication has caught up, you can migrate traffic withMigrateReadsandMigrateWrites.