Convert non-python tests to GitHub actions#5487
Merged
morgo merged 1 commit intovitessio:masterfrom Nov 29, 2019
Merged
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
rafael
approved these changes
Nov 28, 2019
Member
rafael
left a comment
rafael
left a comment
There was a problem hiding this comment.
This makes sense to me. Looks good from my perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not heard any negative feedback about GitHub actions, since converting local-example a few weeks ago.
This moves all other tests that don't use Python 2.7 to GitHub actions. Note that
unitis still installing zookeeper and consul from the bootstrap script. I intend to fix this later, so we can get out of the business of distributing zk/consul in our packages, and instead rely on them as system components.unitalso currently requires go 1.12. There is a problem with client TLS authentication in go 1.13 which will need to be investigated.Signed-off-by: Morgan Tocker tocker@gmail.com