Don't use arch in shell scripts#5480
Merged
sougou merged 2 commits intovitessio:masterfrom Dec 1, 2019
Merged
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
PrismaPhonic
approved these changes
Nov 27, 2019
Contributor
PrismaPhonic
left a comment
PrismaPhonic
left a comment
There was a problem hiding this comment.
This is great! Thanks for fixing this!
Signed-off-by: Morgan Tocker <tocker@gmail.com>
teejae
approved these changes
Nov 30, 2019
sougou
approved these changes
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #5434 broke install from source on macOS.
Upon further investigation, it can also break on linux, since
archis not available on Arch Linux etc. As pointed out in google/fscrypt#92 ; thearchcommand should not be relied on for portable scripts.I have changed this case, plus another case that broke on Arch Linux.
Signed-off-by: Morgan Tocker tocker@gmail.com