added fix for e2e intermittent test failure#5479
Merged
sougou merged 2 commits intovitessio:masterfrom Nov 28, 2019
Merged
Conversation
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
sougou
reviewed
Nov 27, 2019
| return cluster.VtgateProcess.Setup() | ||
| err = cluster.VtgateProcess.Setup() | ||
| if err != nil { | ||
| return |
Contributor
There was a problem hiding this comment.
Shouldn't this return the error?
| for _, keyspace := range cluster.Keyspaces { | ||
| for _, shard := range keyspace.Shards { | ||
| isRdOnlyPresent = false | ||
| _ = cluster.VtgateProcess.WaitForStatusOfTabletInShard(fmt.Sprintf("%s.%s.master", keyspace.Name, shard.Name)) |
Contributor
There was a problem hiding this comment.
Same here. It's better to return an error here and propagate it up the call stack.
And same comments below.
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
sougou
approved these changes
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arindam Nayak arindam.nayak@outlook.com.
Fix Description: Earlier, when we start vtgate, we were not waiting till all tablets are reported healthy to vtgate, that is why test was failing intermittently for some of testcases. With current fix, it will wait before executing any of testcases.