Merged
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
force-pushed
the
morgo-fix-contrib-guide
branch
from
b885275 to
f855a97
Compare
deepthi
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of weeks back I changed the build so it can use go from anywhere, and reduce some of the ceremony around how Vitess builds.
This had a side-effect where
makewould build Vitess in$GOPATH/bin. Some of the scripts still look for these binaries in$VTROOT/binand not in$PATH(which they really should). This is a quick fix to ensure builds go to$VTROOT/bin.There was a breakage in the steps to the contributing guides, which is now fixed.
Signed-off-by: Morgan Tocker tocker@gmail.com