Skip to content

vrepl: use <keyspace.workflow>#5456

Merged
sougou merged 1 commit intovitessio:masterfrom
planetscale:ss-vrepl-workflow-name
Nov 24, 2019
Merged

vrepl: use <keyspace.workflow>#5456
sougou merged 1 commit intovitessio:masterfrom
planetscale:ss-vrepl-workflow-name

Conversation

@sougou
Copy link
Copy Markdown
Contributor

@sougou sougou commented Nov 24, 2019

Since a workflow belongs to only one keyspace, we can simplify
command line arguments to use the <keyspace.workflow> notation.

Signed-off-by: Sugu Sougoumarane ssougou@gmail.com

Since a workflow belongs to only one keyspace, we can simplify
command line arguments to use the <keyspace.workflow> notation.

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
@sougou sougou requested a review from deepthi November 24, 2019 04:18
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can merge once Travis passes.

@sougou sougou merged commit 7983603 into vitessio:master Nov 24, 2019
@sougou sougou deleted the ss-vrepl-workflow-name branch November 24, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants