Adding xxhash Vindex#5439
Merged
sougou merged 1 commit intovitessio:masterfrom Nov 23, 2019
harshit-gangal:xxhash
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit.gangal@gmail.com>
sougou
approved these changes
Nov 23, 2019
Contributor
sougou
left a comment
There was a problem hiding this comment.
Looks like this is a better alternative than binary_md5. Some people may eventually want a unicode_loose_xxhash eventually.
Member
Author
|
I believe it can be extended to support multi-column Vindex. As the xxHash works on bytes it is sql column type agnostic and also allow multiple bytes to be added to generate a single 64 bit hash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshit Gangal harshit.gangal@gmail.com
Added XXHash 64 Bits Vindex to be used for any sql type that are primarily used as Primary Vindex i.e Numbers / Characters.
XXHash is a high quality hashing algorithm having high performance with high Avalanche effect.
Local Benchmarks: