Skip to content

Do not have concurrency when creating shards in the topo#5436

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:limit-concurrency-topo
Nov 23, 2019
Merged

Do not have concurrency when creating shards in the topo#5436
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:limit-concurrency-topo

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Nov 15, 2019

Description

  • Concurrency in this function could create too many parallel requests to the topology service. We started to see issues in our lockserver for keyspaces with more than 256 shards.
  • Per discussion with @sougou, I think not having concurrency at all is still sufficient and it's not worth to try to have some throttling of the parallelism as we do in other places.

Do not have concurrency when creating shards in the topo
328fa59 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner November 15, 2019 00:39
@rafael
Copy link
Copy Markdown
Member Author

rafael commented Nov 15, 2019

This fixes: #5430

@sougou sougou merged commit 7884c1b into vitessio:master Nov 23, 2019
@rafael rafael mentioned this pull request Dec 11, 2019
Merged
@guidoiaquinti guidoiaquinti mentioned this pull request Jan 23, 2020
Closed
@mdlayher mdlayher mentioned this pull request Dec 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sougou sougou sougou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafael @sougou