Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/topo/memorytopo/file.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (c *Conn) Delete(ctx context.Context, filePath string, version topo.Version
// Check if it's a directory.
if n.isDirectory() {
//lint:ignore ST1005 Delete is a function name
return fmt.Errorf("Delete(%v, %v) failed: it's a directory", c.cell, filePath)
return fmt.Errorf("delete(%v, %v) failed: it's a directory", c.cell, filePath)
}

// Check the version.
Expand Down
6 changes: 3 additions & 3 deletions go/vt/topo/stats_conn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@ func (st *fakeConn) Get(ctx context.Context, filePath string) (bytes []byte, ver
// Delete is part of the Conn interface
func (st *fakeConn) Delete(ctx context.Context, filePath string, version Version) (err error) {
if filePath == "error" {
return fmt.Errorf("Dummy error")
return fmt.Errorf("dummy error")
}
return err
}

// Lock is part of the Conn interface
func (st *fakeConn) Lock(ctx context.Context, dirPath, contents string) (lock LockDescriptor, err error) {
if dirPath == "error" {
return lock, fmt.Errorf("Dummy error")
return lock, fmt.Errorf("dummy error")

}
return lock, err
Expand All @@ -89,7 +89,7 @@ func (st *fakeConn) Watch(ctx context.Context, filePath string) (current *WatchD
// NewMasterParticipation is part of the Conn interface
func (st *fakeConn) NewMasterParticipation(name, id string) (mp MasterParticipation, err error) {
if name == "error" {
return mp, fmt.Errorf("Dummy error")
return mp, fmt.Errorf("dummy error")

}
return mp, err
Expand Down
4 changes: 2 additions & 2 deletions go/vt/vtctl/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func commandVtGateExecute(ctx context.Context, wr *wrangler.Wrangler, subFlags *
qr, err := session.Execute(ctx, subFlags.Arg(0), bindVars)
if err != nil {
//lint:ignore ST1005 function name
return fmt.Errorf("Execute failed: %v", err)
return fmt.Errorf("execute failed: %v", err)
}
if *json {
return printJSON(wr.Logger(), qr)
Expand Down Expand Up @@ -445,7 +445,7 @@ func commandVtTabletExecute(ctx context.Context, wr *wrangler.Wrangler, subFlags
}, subFlags.Arg(1), bindVars, int64(*transactionID), executeOptions)
if err != nil {
//lint:ignore ST1005 function name
return fmt.Errorf("Execute failed: %v", err)
return fmt.Errorf("execute failed: %v", err)
}
if *json {
return printJSON(wr.Logger(), qr)
Expand Down
2 changes: 1 addition & 1 deletion go/vt/workflow/long_polling.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func (m *Manager) HandleHTTPLongPolling(pattern string) {

ctx := context.TODO()
if err := m.NodeManager().Action(ctx, ap); err != nil {
return fmt.Errorf("Action failed: %v", err)
return fmt.Errorf("action failed: %v", err)
}
http.Error(w, "", http.StatusOK)
return nil
Expand Down
2 changes: 1 addition & 1 deletion go/vt/workflow/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ func (m *NodeManager) Action(ctx context.Context, ap *ActionParameters) error {

if n.Listener == nil {
m.mu.Unlock()
return fmt.Errorf("Action %v is invoked on a node without listener (node path is %v)", ap.Name, ap.Path)
return fmt.Errorf("action %v is invoked on a node without listener (node path is %v)", ap.Name, ap.Path)
}
nodeListener := n.Listener
m.mu.Unlock()
Expand Down