Skip to content

Stop nagging about where go is installed#5407

Merged
morgo merged 1 commit intovitessio:masterfrom
planetscale:morgo-fix-git-check
Nov 5, 2019
Merged

Stop nagging about where go is installed#5407
morgo merged 1 commit intovitessio:masterfrom
planetscale:morgo-fix-git-check

Conversation

@morgo
Copy link
Copy Markdown
Contributor

@morgo morgo commented Nov 5, 2019

Fixes #5405

I have verified with make docker_bootstrap && go run test.go -pull=false. Currently, the prepared statements test fails (expected), but the other tests pass.

Signed-off-by: Morgan Tocker tocker@gmail.com

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo merged commit 65728ca into vitessio:master Nov 5, 2019
@morgo morgo deleted the morgo-fix-git-check branch November 5, 2019 22:06
Copy link
Copy Markdown
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not warn about GOROOT not compatible with gobinary

3 participants