Merged
Conversation
saifalharthi
reviewed
Nov 1, 2019
Contributor
There was a problem hiding this comment.
I think we should rename it to multi-region-vindex or something that can convey what it will do clearly
Contributor
|
using |
Contributor
I agree :-) If we want to get pedantic, legal jurisdictions are not purely by a geographical scheme. We just think of them like that. |
Contributor
Author
|
For now, I'll go with |
deepthi
reviewed
Nov 3, 2019
The IsFunctional support function was mostly unused. The only place left was in the vstreamer. It was protecting from a vstreamer using a lookup vindex because vstreamer doesn't have a VCursor. This is now addressed by the lookup vindexes checking for VCursor being nil. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Bind var initialization was duplicated in different parts of the primitive. It's now unified and done after all the vindexes are processed. Also, the primary vindex code was flattening the vindex values because it assumed only one column. The code has been rewritten to not assume this. This prepares us for the next step, which is to implement MapNew that will accept multi-column vindex values. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
reviewed
Nov 5, 2019
deepthi
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #5375
A new
geo_experimentalvindex has been created to showcase the new capabilities. The vindex combines a region and an id to generate a keyspace_id. At the same time, it saves a lookup entry from id to keyspace_id.