Fix usage of arch to work on OSX#5384
Merged
morgo merged 1 commit intovitessio:masterfrom Nov 5, 2019
Merged
Conversation
On OS X, the arch command returns "i386". However, "uname -m" returns x86_64, which is the value the rest of the bootstrap.sh script expects. This commit writes a function "get_arch" to wrap the "arch" command, which calls uname on OS X and arch on Linux Signed-off-by: Ben Muschol <ben.muschol@airbnb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OS X, the arch command returns
i386. However,uname -mreturns
x86_64, which is the value the rest of the bootstrap.sh scriptexpects. This commit writes a function
get_archto wrap thearchcommand, which calls
unameon OS X and arch on LinuxTesting
Tested on my Mac, the script completed successfully
Signed-off-by: Ben Muschol ben.muschol@airbnb.com