Skip to content

EmergencyReparentShard does not need to update shard master#5363

Merged
enisoc merged 1 commit intovitessio:reparent-refactorfrom
planetscale:ds-ers
Oct 28, 2019
Merged

EmergencyReparentShard does not need to update shard master#5363
enisoc merged 1 commit intovitessio:reparent-refactorfrom
planetscale:ds-ers

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Oct 27, 2019

Once the new master's type is changed, it will update the shard record.

Signed-off-by: deepthi deepthi@planetscale.com

…er will do it

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner October 27, 2019 02:39
@deepthi deepthi requested a review from enisoc October 27, 2019 02:39
@morgo morgo added this to the v4.0 milestone Oct 28, 2019
Copy link
Copy Markdown
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enisoc enisoc merged commit 789a0e3 into vitessio:reparent-refactor Oct 28, 2019
@enisoc enisoc deleted the ds-ers branch October 28, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants