vttablet-up and vtgate-up should block until ready#5360
Merged
sougou merged 3 commits intovitessio:masterfrom Oct 28, 2019
Merged
vttablet-up and vtgate-up should block until ready#5360sougou merged 3 commits intovitessio:masterfrom
sougou merged 3 commits intovitessio:masterfrom
Conversation
shellcheck is temporarily disabled due to vitessio#5305 No new shellcheck issues should be introduced, but there are existing problems with vtgate-up.sh and vttablet-up.sh which are not addressed. Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
changed the title
sougou
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5355
shellcheck is temporarily disabled due to #5305
No new shellcheck issues should be introduced, but there are existing
problems with vtgate-up.sh and vttablet-up.sh which are not addressed.
Edit: I have also refactored the
local_exampletest to be split into two. Thelocal_examplejust covers the get-started guide from vitess.io. The {python,go,java,jdbc} client tests are inclient_test. This was done so that it follows complete logical sense: as we update the get-started guide, we should update the test to be identical.Signed-off-by: Morgan Tocker tocker@gmail.com