migrater: option to cancel a migration#5347
Merged
sougou merged 4 commits intovitessio:masterfrom Oct 28, 2019
Merged
Conversation
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Oct 25, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good except for one error message.
| } | ||
| if cancelMigrate { | ||
| mi.wr.Logger().Infof("Cancel was requested.") | ||
| mi.cancelMigration(ctx, sm) |
Collaborator
There was a problem hiding this comment.
Error message in line 682 should be changed, it seems to be the same as the one above it.
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a MigrateWrites fails, and also fails to undo what it's done. You can explicitly ask for a retry of the cancelation with this new option.