Skip to content

Add division operator for sql parser#5338

Merged
sougou merged 9 commits intovitessio:masterfrom
planetscale:j0_division
Oct 24, 2019
Merged

Add division operator for sql parser#5338
sougou merged 9 commits intovitessio:masterfrom
planetscale:j0_division

Conversation

@J0
Copy link
Contributor

@J0 J0 commented Oct 21, 2019

implementation of division operator from #5098

J0 added 5 commits October 18, 2019 12:29
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
@J0 J0 marked this pull request as ready for review October 23, 2019 21:16
@J0 J0 requested a review from sougou as a code owner October 23, 2019 21:16
J0 added 3 commits October 23, 2019 14:17
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
Signed-off-by: j0 <lee.yi.jie.joel@gmail.com>
@J0 J0 changed the title [WIP]: Add division operator for sql parser Add division operator for sql parser Oct 23, 2019
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@sougou sougou merged commit 3725ed3 into vitessio:master Oct 24, 2019
@J0 J0 deleted the j0_division branch October 24, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants