migrater: reverse_replication and other solidification#5325
Merged
sougou merged 7 commits intovitessio:masterfrom Oct 24, 2019
Merged
migrater: reverse_replication and other solidification#5325sougou merged 7 commits intovitessio:masterfrom
sougou merged 7 commits intovitessio:masterfrom
Conversation
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
deepthi
approved these changes
Oct 21, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good except for a minor doc fix.
go/vt/wrangler/migrater.go
Outdated
| } | ||
|
|
||
| journalsExist, err := mi.checkJournals(ctx) | ||
| // If not journals exist, sourceWorkflows will be initialized by sm.MigrateStreams. |
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation only created the reverse replication streams, but there was no option to start them. This change introduces the flag and the functionality to start the reverse replication.
The overall order of operations have been adjusted to make more logical sense with respect to reverse replication.
The reverse replication now receives a more user friendly
reverse_workflowname which makes things more understandable.This change also addresses a special corner case: once the migration is fully done, the last action is to delete the target vreplication streams. But if this operation fails partially, the user has to manually delete the left over streams. Re-attempting the migrate command will likely result in errors about the streams being inconsistent. This delete is now done in two phases: First, the streams are marked as frozen, and then deleted. This also gives us the opportunity to check for this flag right at the beginning. If we detect that any of the streams are frozen, we directly skip forward and just delete the left over streams.
The migration cancel has also been hardened. It now performs the cancel based on the original data structures that were built. The previous algorithm of re-reading the data separately was confusing and less maintainable.