Make SetMaster idempotent.#5300
Merged
enisoc merged 1 commit intovitessio:reparent-refactorfrom Oct 15, 2019
Merged
Conversation
enisoc
force-pushed
the
set-master
branch
2 times, most recently
from
230da69 to
a90f6d9
Compare
deepthi
approved these changes
Oct 15, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM. The comments were really helpful in understanding the changes.
Collaborator
|
Test failures look legit, they will need to be resolved before merging. |
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
enisoc
force-pushed
the
set-master
branch
2 times, most recently
from
31e6854 to
9a7d12c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is targeting the
reparent-refactorfeature branch, notmaster.Signed-off-by: Anthony Yeh enisoc@planetscale.com