Skip to content

unit tests for shard watch#5296

Merged
deepthi merged 2 commits intovitessio:reparent-refactorfrom
planetscale:ds-shard-watch-tests
Oct 15, 2019
Merged

unit tests for shard watch#5296
deepthi merged 2 commits intovitessio:reparent-refactorfrom
planetscale:ds-shard-watch-tests

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Oct 12, 2019

NOTE: This PR is targeting the reparent-refactor feature branch, not master.

Signed-off-by: deepthi deepthi@planetscale.com

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner October 12, 2019 04:27
@deepthi deepthi requested a review from enisoc October 12, 2019 04:27
Copy link
Copy Markdown
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comment update.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi merged commit 6abaa03 into vitessio:reparent-refactor Oct 15, 2019
@deepthi deepthi deleted the ds-shard-watch-tests branch October 15, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants