Merged
Conversation
The new TER in wrangler skipped setting the master term start time. Now we start a master term if ChangeType() is called with type MASTER. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Member
Author
|
Remaining broken tests after this fix are unit, unit_race, and vtgate_buffer. I'll look into these next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new TER in wrangler skipped setting the master term start time.
Now we start a master term if ChangeType() is called with type MASTER.
Also switched shard_sync from SlaveWasRestarted() to ChangeType() after realizing ChangeType() already does what I wanted. SlaveWasRestarted() is a legacy API that actually isn't needed anymore because its purpose is to update topo fields that no longer exist.
Signed-off-by: Anthony Yeh enisoc@planetscale.com