tabletmanager: Keep tablet and shard in sync.#5264
Merged
deepthi merged 2 commits intovitessio:reparent-refactorfrom Oct 4, 2019
Merged
tabletmanager: Keep tablet and shard in sync.#5264deepthi merged 2 commits intovitessio:reparent-refactorfrom
deepthi merged 2 commits intovitessio:reparent-refactorfrom
Conversation
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
In particular, if we know we're master but the shard record is wrong, update it. And if another tablet takes over the shard record by having a more recent master term start time, we know we need to stop claiming to be master. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
deepthi
approved these changes
Oct 4, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Approving for merge into feature branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, if we know we're master but the shard record is wrong,
update it. And if another tablet takes over the shard record by having a
more recent master term start time, we know we need to stop claiming to
be master.
Note: This is only merging into a feature branch for a WIP refactor.