Skip to content

Delete unused const #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuxiaobo96 wants to merge 1 commit into from
Closed

Delete unused const #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion go/cmd/vtbackup/vtbackup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ import (

const (
backupTimestampFormat = "2006-01-02.150405"
manifestFileName = "MANIFEST"
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of these constants will go away once #5160 is merged.


// operationTimeout is the timeout for individual operations like fetching
// the master position. This does not impose an overall timeout on
Expand Down
2 changes: 0 additions & 2 deletions go/vt/mysqlctl/replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,8 @@ const (
//lint:ignore U1000 needed for correct indexing of result columns
colConnectionID = iota
//lint:ignore U1000 needed for correct indexing of result columns
colUsername
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to keep these fields as described in the comments.

colClientAddr
//lint:ignore U1000 needed for correct indexing of result columns
colDbName
colCommand
)

Expand Down