Reparent: add ability to watch shard data#5236
Merged
deepthi merged 1 commit intovitessio:reparent-refactorfrom Sep 26, 2019
Merged
Reparent: add ability to watch shard data#5236deepthi merged 1 commit intovitessio:reparent-refactorfrom
deepthi merged 1 commit intovitessio:reparent-refactorfrom
Conversation
enisoc
reviewed
Sep 26, 2019
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-add-shard-watch
branch
from
94ffce0 to
13494ed
Compare
enisoc
reviewed
Sep 26, 2019
Member
enisoc
left a comment
enisoc
left a comment
There was a problem hiding this comment.
LGTM so far. I guess we'll wait for tests even though it's merging into a feature branch, so we don't forget to add them.
enisoc
approved these changes
Sep 26, 2019
Member
enisoc
left a comment
enisoc
left a comment
There was a problem hiding this comment.
Approving what's there so far. We're only merging into a feature branch, so we can merge early and often.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests to be added.
Signed-off-by: deepthi deepthi@planetscale.com