Skip to content

Redact password from error log#5197

Merged
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:fix-password-not-redactec
Sep 17, 2019
Merged

Redact password from error log#5197
sougou merged 1 commit intovitessio:masterfrom
tinyspeck:fix-password-not-redactec

Conversation

@rafael
Copy link
Member

@rafael rafael commented Sep 17, 2019 •
edited
Loading

Desc

  • Mysql could have the master password in the error log. Make sure it gets redacted here too.

Test

  • I validated this fix in our environment and verified that password gets redacted as expected.

The error coming from mysql could have the password. We need to redact
7922f45 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner September 17, 2019 20:20
@rafael rafael changed the title The error coming from mysql could have the password. We need to redact Redact password from error log Sep 17, 2019
@sougou sougou merged commit 1f8c0c5 into vitessio:master Sep 17, 2019
@rafael rafael deleted the fix-password-not-redactec branch September 18, 2019 18:27
@spark4 spark4 mentioned this pull request Nov 13, 2019
Closed
@spark4 spark4 mentioned this pull request Nov 22, 2019
Merged
@rafael rafael mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sougou sougou sougou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafael @sougou