vtbackup: Retry fetching master position.#5192
Merged
enisoc merged 1 commit intovitessio:masterfrom Sep 16, 2019
Merged
Conversation
deepthi
approved these changes
Sep 14, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
lgtm, except for 1 nit.
go/cmd/vtbackup/vtbackup.go
Outdated
Collaborator
There was a problem hiding this comment.
nit: "Not retrying after error:"
We've seen that this could get stuck if vtbackup happens to read the master tablet record while the tablet is unreachable, and then the tablet comes back up with a different address. This adds a retry that re-reads the shard and tablet records to pick up any changes in the master alias or tablet address. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
enisoc
force-pushed
the
vtbackup-retry
branch
from
37cdee1 to
dd6a0e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen that this could get stuck if vtbackup happens to read the
master tablet record while the tablet is unreachable, and then the
tablet comes back up with a different address. This adds a retry that
re-reads the shard and tablet records to pick up any changes in the
master alias or tablet address.
Signed-off-by: Anthony Yeh enisoc@planetscale.com