Skip to content

messaging: move topic handling to vtgate #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
derekperkins wants to merge 1 commit into from
Closed

messaging: move topic handling to vtgate #5181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions proto/vschema.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ message Vindex {

// Table is the table info for a Keyspace.
message Table {
// If the table is a sequence, type must be
// "sequence". Otherwise, it should be empty.
// If the table is a sequence, type must be "sequence".
// If the table is a topic, type must be "topic".
string type = 1;
// column_vindexes associates columns to vindexes.
repeated ColumnVindex column_vindexes = 2;
Expand All @@ -83,6 +83,8 @@ message Table {
// an authoritative list for the table. This allows
// us to expand 'select *' expressions.
bool column_list_authoritative = 6;
// subscription defines a relationship to a topic table.
Subscription subscription = 7;
}

// ColumnVindex is used to associate a column to a vindex.
Expand Down Expand Up @@ -114,3 +116,30 @@ message SrvVSchema {
map<string, Keyspace> keyspaces = 1;
RoutingRules routing_rules = 2;
}

// A Subscription defines a table relationship to a topic
message Subscription {
// The topic must match a table of type TOPIC.
string topic = 1;
// TODO: filters are for a future PR. I am including a rough
// design here to help flesh out the reasoning behind including
// topic/subscription data in the vschema.
//
// filters allow messages published to a topic to conditionally
// be inserted into the message table. Repeated filters
// are ANDed together.
repeated SubscriptionFilter filters = 2;
}

// SubscriptionFilters describe matching rules for subscriptions.
// https://docs.aws.amazon.com/sns/latest/dg/sns-subscription-filter-policies.html
message SubscriptionFilter {
// valid values are "whitelist" or "blacklist"
string type = 1;
// column references a json column of type map<string, string>
Column column = 2;
// key references a value in the specified json column
string key = 3;
// vals specifies valid match values
repeated string vals = 4;
}