xtrabackup: Make sure all files are closed before writing MANIFEST.#5177
Merged
enisoc merged 2 commits intovitessio:masterfrom Sep 10, 2019
Merged
Conversation
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
We've observed a backup that was missing files, yet had a MANIFEST. In the built-in backup engine, the contract was that the MANIFEST file must not be written unless all files were confirmed to have been uploaded successfully. In XtraBackup mode, we were not meeting this contract because an error that occurred while closing a file would not be noticed until after we had written the MANIFEST. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've observed a backup that was missing files, yet had a MANIFEST.
In the built-in backup engine, the contract was that the MANIFEST file
must not be written unless all files were confirmed to have been
uploaded successfully. In XtraBackup mode, we were not meeting this
contract because an error that occurred while closing a file would not
be noticed until after we had written the MANIFEST.